[libcxx-commits] [PATCH] D155349: [libc++][hardening] Categorize most assertions inside the container classes.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

I didn't do another review, but my concerns have been addressed. Since Louis is happy, I'm happy too.



================
Comment at: libcxx/include/__config:252
+//
+// - `_LIBCPP_ASSERT_VALID_ALLOCATOR` -- checks any operations that merge or swap containers to make sure the containers
+//   have compatible allocators.
----------------
var-const wrote:
> Mordante wrote:
> > I expect in the future there might be other tests on allocators. So I think using a longer name leaves more space for future naming.
> How about `_LIBCPP_ASSERT_COMPATIBLE_ALLOCATOR`?
I like that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155349/new/

https://reviews.llvm.org/D155349