[libcxx-commits] [PATCH] D155262: [libc++][print] Adds stdout functions.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 7 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/test/std/input.output/iostream.format/print.fun/check-stdout.sh:5-6
+
+# The expected output for println has "...\n". The escaped newline needs
+# to be expanded before comparing the output with the expected output.
+echo -ne ${expected_stdout} > expected.log
----------------
ldionne wrote:
> 
This file has been removed.


================
Comment at: libcxx/test/std/input.output/iostream.format/print.fun/print.sh.cpp:32-33
+// FILE_DEPENDENCIES: check-stdout.sh
+// RUN: %{build}
+// RUN: %{exec} bash check-stdout.sh "%t.exe" "1234 一二三四 true 0x0"
+
----------------
ldionne wrote:
> I think this would work, and it would be a bit simpler cause it would only use the Lit internal shell. We could also remove the dependency on `executor-has-no-bash` and the `FILE_DEPENDENCIES`.
I tried the suggested approach, but that didn't entirely work, so did it slightly different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155262/new/

https://reviews.llvm.org/D155262