[libcxx-commits] [PATCH] D154489: [libc++][tests] Fix a test exercising incorrect overload

Piotr Fusik via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 20 04:59:46 PDT 2023


pfusik added a comment.

@ldionne Can we please continue this review before the 17.0 branch is created?

The constructor to be tested is not a template and the allocator of the moved string must be the same type as `stringbuf`'s allocator.
It was not: the string had a default `std::allocator` while `stringbuf` had `test_allocator`.
A different overload was selected that allows a different allocator and we have a different test for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154489/new/

https://reviews.llvm.org/D154489



More information about the libcxx-commits mailing list