[libcxx-commits] [libcxx] d16115d - [libc++] Fix tests for the runtime assertions in <barrier>

[David Spickett via libcxx-commits]

Author: Edoardo Sanguineti
Date: 2023-07-20T08:15:02Z
New Revision: d16115ddfcc4ec1c032ef6f879e864080a25f03e

URL: https://github.com/llvm/llvm-project/commit/d16115ddfcc4ec1c032ef6f879e864080a25f03e
DIFF: https://github.com/llvm/llvm-project/commit/d16115ddfcc4ec1c032ef6f879e864080a25f03e.diff

LOG: [libc++] Fix tests for the runtime assertions in <barrier>

As @ldionne pointed out to me in a newer revision, there is a //REQUIRE comment in both files edited by this patch that prevents the test to run on some platforms where it should actually run.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D155755

Added: 
    

Modified: 
    libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
    libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp b/libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
index e36f8bc15a8aaa..b0ee1c2ff66b81 100644
--- a/libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
+++ b/libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
@@ -7,12 +7,11 @@
 //===----------------------------------------------------------------------===//
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode
 
-// REQUIRES: availability-synchronization_library-missing
-// XFAIL: target={{.+}}-apple-macosx10.{{13|15}}
+// XFAIL: availability-verbose_abort-missing
 
 // REQUIRES: has-unix-headers
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
 
 // <barrier>
 

diff  --git a/libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp b/libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp
index 10641ebf0c14fb..161fb72d8f4416 100644
--- a/libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp
+++ b/libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp
@@ -7,12 +7,11 @@
 //===----------------------------------------------------------------------===//
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode
 
-// REQUIRES: availability-synchronization_library-missing
-// XFAIL: target={{.+}}-apple-macosx10.{{13|15}}
+// XFAIL: availability-verbose_abort-missing
 
 // REQUIRES: has-unix-headers
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
 
 // <barrier>