[libcxx-commits] [PATCH] D155554: [libcxx] [test] Fix running tests with Clang-cl in Debug mode

Wed Jul 19 23:55:53 PDT 2023

mstorsjo added a comment.

In D155554#4516731 <https://reviews.llvm.org/D155554#4516731>, @ldionne wrote:

> What would this patch look like if we supported Clang 16 and Clang 17 but not Clang 15? It would be a lot simpler right? I am asking because we're branching in less than a week, so it might be worth punting this change to after that.
>
> Edit: Nevermind, I just saw D155562 <https://reviews.llvm.org/D155562>.

Yeah, indeed. Using the new Clang 16 option doesn't make a big difference (it actually makes for slightly more code changes), but it is structurally more of the right thing to do in the long run. So it doesn't really make any difference for this patch whether we have that allowed yet or not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155554/new/

https://reviews.llvm.org/D155554