[libcxx-commits] [PATCH] D155760: [libcxx] Fix "copy_move.pass" test

Wed Jul 19 16:30:56 PDT 2023

ldionne added a comment.

In D155760#4516670 <https://reviews.llvm.org/D155760#4516670>, @haowei wrote:

> In D155760#4516664 <https://reviews.llvm.org/D155760#4516664>, @ldionne wrote:
>
>> I reverted this change. As a matter of policy, please do not commit patches to libc++ unless the libc++ review group is green. The review process we follow is documented here: https://libcxx.llvm.org/Contributing.html#the-review-process -- it is a bit stricter than the usual LLVM review process because we have an automatically-added review group.
>>
>> Furthermore, the change itself looked wrong, see my comment.
>
> OK, I will pay attention next time.
>
> I see why my patch works in the local test now.
> That tag wasn't defined.

No worries, you'll know for next time!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155760/new/

https://reviews.llvm.org/D155760