[libcxx-commits] [PATCH] D155755: [libc++] Fix tests for the runtime assertions in <barrier>

[Edo via Phabricator via libcxx-commits]

diamante0018 created this revision.
Herald added a project: All.
diamante0018 requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

As a reviewer pointed out to me in a newer revision, there is a //REQUIRE comment in both files edited by this patch that prevents the test to run on some platforms where it should actually run.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155755

Files:
  libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
  libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp


Index: libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp
===================================================================
--- libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp
+++ libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp
@@ -7,12 +7,11 @@
 //===----------------------------------------------------------------------===//
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode
 
-// REQUIRES: availability-synchronization_library-missing
-// XFAIL: target={{.+}}-apple-macosx10.{{13|15}}
+// XFAIL: availability-verbose_abort-missing
 
 // REQUIRES: has-unix-headers
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
 
 // <barrier>
 
Index: libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
===================================================================
--- libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
+++ libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
@@ -7,12 +7,11 @@
 //===----------------------------------------------------------------------===//
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode
 
-// REQUIRES: availability-synchronization_library-missing
-// XFAIL: target={{.+}}-apple-macosx10.{{13|15}}
+// XFAIL: availability-verbose_abort-missing
 
 // REQUIRES: has-unix-headers
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
 
 // <barrier>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155755.542205.patch
Type: text/x-patch
Size: 1562 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230719/0220334a/attachment-0001.bin>