[libcxx-commits] [PATCH] D155521: Run picolibc tests with qemu

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added inline comments.


================
Comment at: libcxx/test/libcxx/selftest/convenience_substitutions/build_run.sh.cpp:9
 
+// Command line arguments not supported.
+// XFAIL: LIBCXX-PICOLIBC-FIXME
----------------
Can be handled by the qemu script but that can always be a follow up change.


================
Comment at: libcxx/utils/run-qemu.sh:16
+    -chardev stdio,mux=on,id=stdio0 \
+    -semihosting-config enable=on,chardev=stdio0 \
+    -monitor none \
----------------
The `arg=` semihosting flag can be used to create argv.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155521/new/

https://reviews.llvm.org/D155521