[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:102
+    Feature(
+        name="atomics",
+        when=lambda cfg: sourceBuilds(
----------------
This is effectively checking for availability of 64-bit atomics (since uintmax_t essentially has to be the same as uint64_t for ABI reasons). Maybe something like has-64-bit-atomics is more accurate? I believe this will fail for 32 bit arm picolibc since that needs a libatomic runtime function. The other larger libatomic requirements should already be handled by non-lockfree-atomics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246