[libcxx-commits] [PATCH] D153201: [libc++] Adds string_view constructor overload

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 3 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/include/bitset:835
 
+#if _LIBCPP_STD_VER >= 26
+template <size_t _Size>
----------------
philnik wrote:
> Mordante wrote:
> > philnik wrote:
> > > Given that we want to move away from defining member functions out-of-line, maybe we want to jut define the new functions inline directly?
> > Do we? I must have missed that message. When/where was this discussed? (I'm not objecting against it.)
> I don't think we ever discussed this explicitly, but that's how we write every new class, so I don't see why that would be different for pre-existing classes. So I guess I'm assuming consensus on this based on how people write code.
I see. I don't object so I inlined the new constructor too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153201/new/

https://reviews.llvm.org/D153201