[libcxx-commits] [PATCH] D155366: [libc++][format] Improves run-time diagnostics.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 8 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/include/__format/parser_std_format_spec.h:241-247
+inline constexpr uint32_t __type_mask_integer =
+    __create_type_mask<__type::__binary_lower_case,
+                       __type::__binary_upper_case,
+                       __type::__decimal,
+                       __type::__octal,
+                       __type::__hexadecimal_lower_case,
+                       __type::__hexadecimal_upper_case>();
----------------
ldionne wrote:
> WDYT about this? Then the `consteval` overload can be removed and IMO it's a bit more clear what's going on.
I like the original code slightly better, but I don't object against the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155366/new/

https://reviews.llvm.org/D155366