[libcxx-commits] [PATCH] D150044: [libc++][print] Adds FILE functions.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/src/print.cpp:51-52
+#    ifndef _LIBCPP_HAS_NO_EXCEPTIONS
+    // There is no __throw_system_error overload that takes an
+    // error code.
+    throw system_error{filesystem::detail::make_windows_error(GetLastError()), "failed to write formatted output"};
----------------
ldionne wrote:
> Mordante wrote:
> > This changes back to the original version. The function `__throw_system_error` is in the dylib but has no error code overload. I don't think we need to add an overload for one usage.
> We could add an overload in another patch to address https://reviews.llvm.org/D154995#inline-1500381 at the same time.
As discussed I'll do that in a follow-up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150044/new/

https://reviews.llvm.org/D150044