[libcxx-commits] [PATCH] D155554: [libcxx] [test] Fix running tests with Clang-cl in Debug mode

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 18 08:41:33 PDT 2023


Mordante added a comment.

In general LGTM, but one question.



================
Comment at: libcxx/test/support/set_windows_crt_report_mode.h:13
 
+#if defined(__cplusplus) && __cplusplus > 199711L
 #ifndef _DEBUG
----------------
Why do we need to test for C+98? If needed can you use our normal `TEST_STD_VER` macro?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155554/new/

https://reviews.llvm.org/D155554



More information about the libcxx-commits mailing list