[libcxx-commits] [PATCH] D155531: [libc++][PSTL] Simplify the partitioning algorithm until we have better data to know how to chunk better

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 18 07:39:57 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/src/pstl/libdispatch.cpp:12
 #include <__config>
 #include <dispatch/dispatch.h>
 #include <memory_resource>
----------------
You can likely minimize some includes.


================
Comment at: libcxx/test/libcxx/algorithms/pstl.libdispatch.chunk_partitions.pass.cpp:11
 
-// REQUIRES: libcpp-pstl-cpu-backend-libdispatch
+// REQUIRES-: libcpp-pstl-cpu-backend-libdispatch
 
----------------
This shouldn't be needed even in your WIP patches. This should be enabled by default on the `apple-system` job.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155531/new/

https://reviews.llvm.org/D155531



More information about the libcxx-commits mailing list