[libcxx-commits] [PATCH] D155397: [libc++][format] Fixes an off by one error.

Tue Jul 18 07:37:17 PDT 2023

ldionne added a comment.

In D155397#4510120 <https://reviews.llvm.org/D155397#4510120>, @avogelsgesang wrote:

> In D155397#4506191 <https://reviews.llvm.org/D155397#4506191>, @ldionne wrote:
>
>> Did you find that with fuzzing?
>
> We (a small team inside Salesforce) found this in one of our production builds by accident / sheer luck. We are using `-fexperimental-library` already, because we recompile the world anyway (and don't need ABI stability) and are happy to rewrite our code in case breaking API changes are applied to libc++ or the C++ standard.
>
> I agree that fuzzing might be a good idea for `std::format` to find this type of issues in a more structured way

Thanks for the context!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155397/new/

https://reviews.llvm.org/D155397