[libcxx-commits] [PATCH] D154305: [libc++][PSTL] Parallelize random_access_iterator

[Gonzalo Brito Gadeschi via Phabricator via libcxx-commits]

gonzalobg added inline comments.


================
Comment at: libcxx/include/__iterator/concepts.h:290
   copyable<iter_value_t<_In>> &&
   constructible_from<iter_value_t<_In>, iter_reference_t<_In>> &&
   assignable_from<iter_value_t<_In>&, iter_reference_t<_In>>;
----------------
philnik wrote:
> ldionne wrote:
> > (not attached to the diff) Can you folks think of a way to test this? I can't, but asking just in case.
> We already test with C++20 iterators, which should be good enough I think. Performance can only be tested through benchmarks anyways, so I think that's out of scope for this, since we don't have any PSTL benchmarks yet. (Reminds me that we should log the result of our benchmarks...)
> (not attached to the diff) Can you folks think of a way to test this? I can't, but asking just in case.

I don't know how to test this (I thought quite a bit about it, but benchmarks are the only way I have to test this right now).

If someone figures out a way to test this without requiring benchmarks, that would be helpful for libstdc++ as well (I've sent a similar patch there).




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154305/new/

https://reviews.llvm.org/D154305