[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Michael Platings via Phabricator via libcxx-commits]

michaelplatings added inline comments.


================
Comment at: libcxx/test/std/atomics/atomics.types.generic/integral.pass.cpp:9
 
+// XFAIL: !atomics
+
----------------
michaelplatings wrote:
> philnik wrote:
> > I would just go with `// REQUIRES: atomics`. That's a lot less confusing that the double negation.
> I went with `XFAIL` for consistency with `non-lockfree-atomics`. `REQUIRES` means the tests won't be run at all, but I'm OK with that.
The [[ https://reviews.llvm.org/B246016 | CI results with XFAIL: !atomics ]] suggest that the code to detect atomics support was incorrect. REQUIRES wouldn't have picked that up so I feel XFAIL is the better choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246