[libcxx-commits] [PATCH] D154305: [libc++][PSTL] Parallelize random_access_iterator

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__algorithm/pstl_any_all_none_of.h:16
 #include <__iterator/cpp17_iterator_concepts.h>
-#include <__iterator/iterator_traits.h>
+#include <__iterator/concepts.h>
 #include <__type_traits/enable_if.h>
----------------
Why is this include changed, since we didn't touch the contents of the file? Was the include unnecessary in the first place?


================
Comment at: libcxx/include/__algorithm/pstl_find.h:18
 #include <__iterator/cpp17_iterator_concepts.h>
-#include <__iterator/iterator_traits.h>
+#include <__iterator/concepts.h>
 #include <__type_traits/is_execution_policy.h>
----------------
Same comment.


================
Comment at: libcxx/include/__algorithm/pstl_transform.h:15
 #include <__iterator/cpp17_iterator_concepts.h>
-#include <__iterator/iterator_traits.h>
+#include <__iterator/concepts.h>
 #include <__type_traits/is_execution_policy.h>
----------------
Same comment.


================
Comment at: libcxx/include/__iterator/concepts.h:290
   copyable<iter_value_t<_In>> &&
   constructible_from<iter_value_t<_In>, iter_reference_t<_In>> &&
   assignable_from<iter_value_t<_In>&, iter_reference_t<_In>>;
----------------
(not attached to the diff) Can you folks think of a way to test this? I can't, but asking just in case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154305/new/

https://reviews.llvm.org/D154305