[libcxx-commits] [PATCH] D144322: [libc++][Modules] Make top level modules for all C++ headers with OS/clang versions

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/strings/char.traits/char.traits.specializations/arbitrary_char_type.deprecated.verify.cpp:9-10
 
+// This should work for modules too, but clang doesn't emit the diagnostics for unknown reasons.
+// UNSUPPORTED: modules-build
+
----------------
We should have a Clang bug report number associated to this, and it should be `XFAIL: modules-build && clang-<version>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144322/new/

https://reviews.llvm.org/D144322