[libcxx-commits] [PATCH] D155411: [libc++] Implement P2614R2 (Deprecate numeric_limits::has_denorm)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this!



================
Comment at: libcxx/include/limits:46
     static constexpr bool has_signaling_NaN = false;
     static constexpr float_denorm_style has_denorm = denorm_absent;
     static constexpr bool has_denorm_loss = false;
----------------
This should be updated too.


================
Comment at: libcxx/test/std/depr/depr.numeric.imits.has.denorm/deprecated.verify.cpp:19
+  std::numeric_limits<bool>::has_denorm;      // expected-warning {{'has_denorm' is deprecated}}
+  std::numeric_limits<bool>::has_denorm_loss; // expected-warning {{'has_denorm_loss' is deprecated}}
+
----------------
I would add tests that `denorm_min` does not trigger an deprecated diagnostic. Just to make sure this can be used without triggering a deprecated message. Based on the wording change for `denorm_min` that is intended.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155411/new/

https://reviews.llvm.org/D155411