[libcxx-commits] [PATCH] D155276: [libc++] Implement ostringstream members of P0408R7 (Efficient Access to basic_stringbuf's Buffer)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM after removing the unneeded constraint.



================
Comment at: libcxx/include/sstream:846
     template <class _SAlloc>
+      requires (!is_same_v<_SAlloc, allocator_type>)
     _LIBCPP_HIDE_FROM_ABI explicit basic_istringstream(const basic_string<_CharT, _Traits, _SAlloc>& __s,
----------------
Interestingly this one does not seem to be constrained. http://eel.is/c++draft/string.streams#istringstream.cons-6

The same in the paper. I can't find a reason in the WG21 review either. I assume it's a bug in the Standard. For now let's remove this one and maybe we should file an LWG issue to remove them from the constructors when not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155276/new/

https://reviews.llvm.org/D155276