[libcxx-commits] [PATCH] D155276: [libc++] Implement ostringstream members of P0408R7 (Efficient Access to basic_stringbuf's Buffer)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general LGTM, modulo one nit. I like to have a quick look before the final approval.



================
Comment at: libcxx/include/sstream:967
+    template <class _SAlloc>
+    _LIBCPP_HIDE_FROM_ABI explicit basic_ostringstream(const basic_string<_CharT, _Traits, _SAlloc>& __s,
+                                                       ios_base::openmode __wch = ios_base::out)
----------------
This overload should be constrained `is_same_v<SAlloc,Allocator> is false`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155276/new/

https://reviews.llvm.org/D155276