[libcxx-commits] [PATCH] D155116: [libc++][Modules] Restore the <string> include to <__format/format_functions.h>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D155116#4501682 <https://reviews.llvm.org/D155116#4501682>, @iana wrote:

> In D155116#4501194 <https://reviews.llvm.org/D155116#4501194>, @Mordante wrote:
>
>> I think the change is the wrong direction. `std::format` returns a `std::string`. In my experience arguments and return values often need to be explicitly exported. So I think the proper fix would be to include `string` in this header. The main issue is that accidentally forgotten headers worked in the past.
>
> But you just barely removed that include in D154122 <https://reviews.llvm.org/D154122>

That seems like a mistake on my side.

Thanks for the patch, LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155116/new/

https://reviews.llvm.org/D155116