[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:207
+              int fd[2];
+              return pipe(fd);
             }
----------------
Why pipe? Is that function actually called inside libc++?


================
Comment at: libunwind/test/configs/armv7m-libunwind.cfg.in:20
+))
+config.substitutions.append(('%{exec}',
+    'true'
----------------
There should probably be a comment here such as `todo: run using qemu-system-arm`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246