[libcxx-commits] [PATCH] D155185: [libc++] Work around dynamic linking of stringbuf::str() on Windows

Fri Jul 14 09:54:03 PDT 2023

pfusik added inline comments.

================
Comment at: libcxx/include/sstream:233
+// TODO(LLVM 19): Remove this once we drop support for Clang 16,
+// which had this bug: https://github.com/llvm/llvm-project/issues/40363
+#ifdef _WIN32
----------------
pfusik wrote:
> Mordante wrote:
> > Please add a this link in the commit message too. We've changed bug trackers before so having an explicit link makes it easier to find in the future.
> Why don't I see the updated commit message here? I used `arc diff`.
Nevermind, I found https://secure.phabricator.com/T2386 :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155185/new/

https://reviews.llvm.org/D155185