[libcxx-commits] [PATCH] D155185: [libc++] Work around #40363 for stringbuf::str()

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/sstream:232
 
+// TODO(LLVM 19): Remove this once we drop support for Clang 16,
+// which had this bug: https://github.com/llvm/llvm-project/issues/40363
----------------
This is our typical pattern.


================
Comment at: libcxx/include/sstream:232
 
+// TODO(LLVM 19): Remove this once we drop support for Clang 16,
+// which had this bug: https://github.com/llvm/llvm-project/issues/40363
----------------
Mordante wrote:
> This is our typical pattern.
Note this feels a bit of a hack, however since it's temporary I've no objection.


================
Comment at: libcxx/include/sstream:233
+// TODO(LLVM 19): Remove this once we drop support for Clang 16,
+// which had this bug: https://github.com/llvm/llvm-project/issues/40363
+#ifdef _WIN32
----------------
Please add a this link in the commit message too. We've changed bug trackers before so having an explicit link makes it easier to find in the future.


================
Comment at: libcxx/include/sstream:341
-      requires __is_allocator<_SAlloc>::value
-    _LIBCPP_HIDE_FROM_ABI basic_string<char_type, traits_type, _SAlloc> str(const _SAlloc& __sa) const {
-        return basic_string<_CharT, _Traits, _SAlloc>(view(), __sa);
----------------
Why move this hunk?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155185/new/

https://reviews.llvm.org/D155185