[libcxx-commits] [PATCH] D155271: [libc++][Android] Add Android support to CI Docker image

Fri Jul 14 01:27:41 PDT 2023

rprichard added inline comments.

================
Comment at: libcxx/utils/ci/Dockerfile:131
 ENV PATH="${PATH}:/home/libcxx-builder/.buildkite-agent/bin"
-RUN echo "tags=\"queue=libcxx-builders,arch=$(uname -m),os=linux\"" >> "/home/libcxx-builder/.buildkite-agent/buildkite-agent.cfg"

----------------
I removed this setting in favor of setting an environment variable, e.g.:
```
BUILDKITE_AGENT_TAGS=queue=libcxx-builders,arch=x86_64,os=linux
```
However, if we want to use the same GCE VMs for Android and non-Android Linux, then we could keep setting the tags in the Dockerfile.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155271/new/

https://reviews.llvm.org/D155271