[libcxx-commits] [PATCH] D154626: [libc++] add basic runtime assertions to <barrier>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with comments applied and green CI. Thanks!



================
Comment at: libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp:21-23
+// REQUIRES: has-unix-headers
+// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
+
----------------
We generally try to group Lit annotations like this. Please move those above right under the `XFAIL`. Here and elsewhere.


================
Comment at: libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp:38
+        [] {
+          constexpr auto comp = []() noexcept {};
+          std::barrier<decltype(comp)> b(-1, comp);
----------------
`constexpr` and  `noexcept` are not necessary here, and they make the reader wonder whether they are relevant to the test. I'd remove them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154626/new/

https://reviews.llvm.org/D154626