[libcxx-commits] [PATCH] D153935: [libc++] mdspan - implement default_accessor

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Ship it!

(after a few comments and rebase and green CI)

Thanks!



================
Comment at: libcxx/test/std/containers/views/mdspan/MinimalElementType.h:9-10
+
+#ifndef TEST_STD_CONTAINERS_MINIMAL_ELEMENT_TYPE_H
+#define TEST_STD_CONTAINERS_MINIMAL_ELEMENT_TYPE_H
+
----------------
For the 3 macros within this file.


================
Comment at: libcxx/test/std/containers/views/mdspan/MinimalElementType.h:19
+  constexpr MinimalElementType() = delete;
+  constexpr MinimalElementType(const MinimalElementType&) = delete;
+  constexpr explicit MinimalElementType(int v) noexcept : val(v){}
----------------
Let's be explicit about the fact that this isn't movable either. So delete move ctor and move assignment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153935/new/

https://reviews.llvm.org/D153935