[libcxx-commits] [PATCH] D155185: [libc++] Work around #40363 for stringbuf::str()

Thu Jul 13 06:39:20 PDT 2023

pfusik marked 2 inline comments as done.
pfusik added inline comments.

================
Comment at: libcxx/include/sstream:359
+      requires __is_allocator<_SAlloc>::value
+    _LIBCPP_HIDE_FROM_ABI basic_string<char_type, traits_type, _SAlloc> str(const _SAlloc& __sa) const {
+        return basic_string<_CharT, _Traits, _SAlloc>(view(), __sa);
----------------
hans wrote:
> pfusik wrote:
> > hans wrote:
> > > pfusik wrote:
> > > > hans wrote:
> > > > > Moving this one seems unrelated?
> > > > It **is** related. This overload does not conflict with the pre-C++20 one, so it shouldn't depend on `_LIBCPP_BUILDING_LIBRARY`.
> > > I mean it doesn't seem related to the problem we're working around with _LIBCPP_HIDE_FROM_ABI_SSTREAM, so perhaps it would be better to do it in a separate patch?
> > It's the same problem: overload missing with `_LIBCPP_BUILDING_LIBRARY`, just a different solution.
> > I don't have a strong opinion on whether this should be one patch or two.
> I think because it's a template, this one does not have the linking issues that the others do.
> 
> I also don't feel strongly about this change, just want to make sure I understand it.
Oh, you are right!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155185/new/

https://reviews.llvm.org/D155185