[libcxx-commits] [PATCH] D155038: [libc++][hardening][NFC] Remove the `LIBCXX_DEBUG_BUILD` CMake variable.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 12 10:10:54 PDT 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comment.



================
Comment at: libcxx/CMakeLists.txt:473
 
 string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
 
----------------
Can you move this closer to the first use of the variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155038/new/

https://reviews.llvm.org/D155038



More information about the libcxx-commits mailing list