[libcxx-commits] [PATCH] D154957: [libc++] add test for latch ctor

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM with green CI and the `static_assert` fixed.



================
Comment at: libcxx/test/std/thread/thread.latch/ctor.pass.cpp:24
+
+static_assert(!test_convertible<std::latch>(), "This constructor must be explicit");
+
----------------
You're missing an argument here.

**just thoughts, not an action item for you**
Maybe we should add a new test trait `is_explicit` which is an error if there is no constructor which matches, true if it's not convertible and false if it is. That would catch these kinds of errors.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154957/new/

https://reviews.llvm.org/D154957