[libcxx-commits] [PATCH] D155008: [libc++] Clean up mess around __throw_runtime_error

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 11 13:05:32 PDT 2023


ldionne created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

We were defining the function in locale.cpp, and we actually had two
overloads for it. This is pretty confusing given that one was static
and not exported from the dylib, and the other one was. Instead, use
the vanilla __throw_runtime_error function everywhere even though that
adds a tiny bit of code duplication.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155008

Files:
  libcxx/src/locale.cpp
  libcxx/src/stdexcept.cpp
  libcxx/utils/data/ignore_format.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155008.539256.patch
Type: text/x-patch
Size: 10932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230711/740d53d0/attachment-0001.bin>


More information about the libcxx-commits mailing list