[libcxx-commits] [PATCH] D154286: [libc++][format] Granularize formatter_output.

Tue Jul 11 06:18:44 PDT 2023

hans added a comment.

In D154286#4485940 <https://reviews.llvm.org/D154286#4485940>, @Mordante wrote:

> @hans can you test whether this solves the chromium issue with `vector`. I suspect it doesn't but it would be good to get it confirmed.

For D154122 <https://reviews.llvm.org/D154122> I measure a 8.4 MB decrease, so that one was small as we suspected.

For this new change, we see a 780 MB (0.24%) decrease, which is a nice improvement.

I'm also not sure anymore if the full increase we saw was actually from D149543 <https://reviews.llvm.org/D149543>. The update we did included several libc++ revisions, and that one seemed like a prime suspect, but other changes may have contributed too. It's a bit tricky to bisect because the builds are slow and we can't build at every revision.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154286/new/

https://reviews.llvm.org/D154286