[libcxx-commits] [PATCH] D154700: [libc++] Make `stop_token` experimental

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 11 05:52:13 PDT 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

CI failure is a fluke, merging.



================
Comment at: libcxx/include/__stop_token/stop_callback.h:15
 #include <__concepts/constructible.h>
 #include <__concepts/destructible.h>
 #include <__concepts/invocable.h>
----------------
Mordante wrote:
> ldionne wrote:
> > Mordante wrote:
> > > ldionne wrote:
> > > > Also let's tweak the release note.
> > > I already made changes in my draft update for the release notes ;-)
> > > I still want to look whether we missed other changes, so I probably upload it later today.
> > Oh, nice, thanks for having a review with updates to the release notes. This comment was actually saying that we should update the release notes to account for the fact that this is now experimental, however I realized that we didn't add `stop_token` to the release notes at all, so that's moot. But if you mention `stop_token` in your release notes update, let's mention it as being experimental.
> That's what I already did ;-)
Great, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154700/new/

https://reviews.llvm.org/D154700



More information about the libcxx-commits mailing list