[libcxx-commits] [PATCH] D150766: [libcxx] [ci] Add a test configuration with an incomplete sysroot

Mon Jul 10 23:38:21 PDT 2023

phosek added inline comments.

================
Comment at: libcxx/utils/ci/run-buildbot:675
+          -DCMAKE_C_COMPILER_WORKS=TRUE \
+          -DCMAKE_CXX_COMPILER_WORKS=TRUE \
+          -DCMAKE_C_COMPILER_TARGET=x86_64-w64-windows-gnu \
----------------
mstorsjo wrote:
> ldionne wrote:
> > I would set this unconditionally in `runtimes/CMakeLists.txt` with an appropriate comment. I don't think it ever makes sense for us to rely on the default CMake compiler checking.
> Hmm, I wonder if it's possible (and generally advisable?) to do that. WDYT @phosek?
We already set these in the bootstrapping build, see https://github.com/llvm/llvm-project/blob/e53da3eab42e6efd448c1c60c14668e1eb3d907c/llvm/runtimes/CMakeLists.txt#L239, but I'm not sure if setting this in `runtimes/CMakeFiles.txt` is the right approach since these should be only needed when building runtimes with an incomplete toolchain, and I'm worried if this could be a potential footgun.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150766/new/

https://reviews.llvm.org/D150766