[libcxx-commits] [PATCH] D154454: [libc++] Implement istringstream members of P0408R7 (Efficient Access to basic_stringbuf's Buffer)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: libcxx/include/sstream:813
+    _LIBCPP_HIDE_FROM_ABI basic_istringstream(ios_base::openmode __wch, const _Allocator& __a)
+        : basic_istream<_CharT, _Traits>(&__sb_), __sb_(__wch | ios_base::in, __a) {}
+
----------------
pfusik wrote:
> Mordante wrote:
> > Mordante wrote:
> > > I prefer the wording of the standard, I know the existing code doesn't do that but let's do it for the new code.
> > This item is not done.
> Sorry, I'm still learning Phabricator. It's a little confusing that both "arc diff" and "Submit" on the web submit the "Done" flags.
I didn't know `arc diff` did that. It doesn't for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154454/new/

https://reviews.llvm.org/D154454