[libcxx-commits] [PATCH] D154286: [libc++][format] Granularize formatter_output.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D154286#4485749 <https://reviews.llvm.org/D154286#4485749>, @ldionne wrote:

> LGTM anyway but it would be important to raise this concern, cause doubling the preprocessed size of `<vector>` for a formatter that most code will not make use of (in the near future) is a notable problem.

I agree. I even think in the future this formatter is unlikely to get much usage. This is only needed for `vector<bool>`. `vector<int>` is a normal range and its formatter is not in `<vector>`. As mentioned elsewhere I have a paper where I mention this. To be fully compliant `<vector>` needs to support, among others, `formatter<string, char>` too. (This is not in libc++ yet.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154286/new/

https://reviews.llvm.org/D154286