[libcxx-commits] [PATCH] D148056: libcxx: Bring back unsigned return from wcstoull_l

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 8 04:55:31 PDT 2023


Mordante added a comment.

In D148056#4447081 <https://reviews.llvm.org/D148056#4447081>, @cschlosser wrote:

> In D148056#4332982 <https://reviews.llvm.org/D148056#4332982>, @ldionne wrote:
>
>> In D148056#4263105 <https://reviews.llvm.org/D148056#4263105>, @cschlosser wrote:
>>
>>> Could you commit this for me please?
>>
>> Can you please provide `Author Name <email at domain>` we should use to contribute this with proper attribution?
>
> I thought I added that to the commit but it should be `Christoph Schlosser <cschlosser at google.com>`.

It was there, but it's not always the case.

>>> Also does it make sense to backport to 16?
>>
>> I guess it does.
>>
>> Thanks!
>
> Is there a way to do this from the Web UI or should it go through the same flow as this review?

Based on https://discourse.llvm.org/t/16-0-6-release/71344 there will be no more 16 releases. So it can't be backported.

I just landed this on your behalf so it will be in LLVM 17.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148056/new/

https://reviews.llvm.org/D148056



More information about the libcxx-commits mailing list