[libcxx-commits] [PATCH] D154122: [libc++][format] Removes unneeded includes.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 8 03:38:36 PDT 2023


Mordante added a comment.

In D154122#4481340 <https://reviews.llvm.org/D154122#4481340>, @philnik wrote:

> Out of curiosity, did this actually help with preprocessed code size?

I expect it helps a bit, I'm not convinced this solves the vector issue. I have another patch, but I expect that one not to be enough either. If that doesn't help we can not include `<__format/*.h>` when using C++ < 23 (basically what Hans already proposed). That will solve it for older language versions. When people start to use C++23 they will either have to bite the bullet or start using modules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154122/new/

https://reviews.llvm.org/D154122



More information about the libcxx-commits mailing list