[libcxx-commits] [PATCH] D154723: [libc++][modules] Avoids duplicated exports.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but I'd like to understand how the test will fail.



================
Comment at: libcxx/modules/std/cmath.cppm:142
 
   // [c.math.hypot3], three-dimensional hypotenuse
 
----------------
Is this comment in the right place now?


================
Comment at: libcxx/modules/std/filesystem.cppm:38
 
   // [fs.rec.dir.itr.nonmembers], range access for recursive directory iterators
 
----------------
Same.


================
Comment at: libcxx/test/tools/clang_tidy_checks/header_exportable_declarations.cpp:236
+        // After the warning the script continues.
+        // The test will fail since modules have duplicated entries and headers not.
+        llvm::errs() << "Duplicated export of '" << name << "'.\n";
----------------
This might be dumb, but I don't understand how the test will fail. Can you explain a bit more?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154723/new/

https://reviews.llvm.org/D154723