[libcxx-commits] [PATCH] D154305: [libc++][PSTL] Parallelize random_access_iterator

Fri Jul 7 10:20:52 PDT 2023

philnik added a comment.

Could you upload the patch with context (i.e. use `arc` or add `-U9999` when generating the patch)?

It feels a bit wrong to me that we check for `random_access_iterator` in a classic algorithm, but I guess that is fine. Do all `Cpp17RandomAccessIterator`s meet the `random_access_iterator` requirements? If yes, I'd just go with using either `__has_random_access_iterator` or `random_access_iterator`. We'd probably want to diagnose iterators which advertise themselves as such while not actually being `random_access_iterator`s if we go that route.

================
Comment at: libcxx/include/__algorithm/pstl_traits.h:26
+using __has_random_access_iterator_category_or_concept
+#if _LIBCPP_STD_VER >= 20
+  = disjunction<
----------------
This isn't actually pstl-specific, so IMO this should live in `iterator_traits` or something like that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154305/new/

https://reviews.llvm.org/D154305