[libcxx-commits] [PATCH] D154700: [libc++] Make `stop_token` experimental

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 7 04:56:13 PDT 2023


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/__stop_token/stop_callback.h:23
 #include <__utility/forward.h>
 #include <__utility/move.h>
 
----------------
Let's instead add something like this to `__config`:


```
#  if !defined(_LIBCPP_ENABLE_EXPERIMENTAL) && !defined(_LIBCPP_BUILDING_LIBRARY)
#    define _LIBCPP_HAS_NO_INCOMPLETE_STOP_TOKEN
#  endif
```



================
Comment at: libcxx/test/std/thread/thread.stoptoken/nostopstate/cons.default.pass.cpp:10
 // UNSUPPORTED: no-threads
+// UNSUPPORTED: !c++experimental
 // UNSUPPORTED: c++03, c++11, c++14, c++17
----------------
Here let's introduce a specific Lit feature for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154700/new/

https://reviews.llvm.org/D154700



More information about the libcxx-commits mailing list