[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett added a comment.

We got a green build - https://buildkite.com/llvm-project/libcxx-ci/builds/27739#_

All the infrastructure changes are done, so please libcxx folks proceed with the review as usual.



================
Comment at: libcxx/utils/ci/build-picolibc.sh:69
+[binaries]
+c = ['$CC', '--target=armv6m-none-eabi', '-mfloat-abi=soft', '-nostdlib']
+ar = 'llvm-ar'
----------------
michaelplatings wrote:
> DavidSpickett wrote:
> > Needs to literally be `cc`. As `/usr/local/bin/cc` is linked to clang-16.0.4 in our images, we don't set any env vars.
> > 
> > I know it's not great for anyone reproducing, and an env var would probably be better but cross that road when it's needed.
> Thanks for explaining. Now if `CC` isn't set then `cc` will be used.
Nice, that's much more convenient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246