[libcxx-commits] [PATCH] D154590: [libc++] mark barrier constructor as constexpr explicit in <barrier>

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

There is no need to add `inline` everywhere. In these cases it most likely doesn't actually do anything. Please add tests that the constructor is `constexpr` and `explicit`. You can test the `constexpr` by adding a gloabl `constinit` variable and the `explicit` by making sure that `is_convertible_v<...>` is false.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154590/new/

https://reviews.llvm.org/D154590