[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Michael Platings via Phabricator via libcxx-commits]

michaelplatings marked an inline comment as done.
michaelplatings added inline comments.


================
Comment at: libcxx/utils/ci/build-picolibc.sh:69
+[binaries]
+c = ['$CC', '--target=armv6m-none-eabi', '-mfloat-abi=soft', '-nostdlib']
+ar = 'llvm-ar'
----------------
DavidSpickett wrote:
> Needs to literally be `cc`. As `/usr/local/bin/cc` is linked to clang-16.0.4 in our images, we don't set any env vars.
> 
> I know it's not great for anyone reproducing, and an env var would probably be better but cross that road when it's needed.
Thanks for explaining. Now if `CC` isn't set then `cc` will be used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246