[libcxx-commits] [PATCH] D154499: [libc++] Do not use stringbuf's string after move

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 6 10:24:44 PDT 2023


Mordante added a comment.

In D154499#4474853 <https://reviews.llvm.org/D154499#4474853>, @pfusik wrote:

> @philnik Are the tests for libc++ or the C++ standard? The former does specify the state.
>
> Before this change, the pointers were pointing to the string *after* the move, i.e. an empty string. I don't understand what would you like to test here?

Thanks for working on this!

tests in the directory `test/std` are for the C++ standard. You can use `LIBCPP_ASSERT` for libc++ specific asserts.
tests in the directory `test/libcxx` are always libc++ specific tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154499/new/

https://reviews.llvm.org/D154499



More information about the libcxx-commits mailing list