[libcxx-commits] [PATCH] D153216: [libc++][Modules] Add missing includes to public headers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 5 14:00:52 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/include/memory_resource:53
 #include <__config>
+#include <__fwd/memory_resource.h>
 #include <__memory_resource/memory_resource.h>
----------------
philnik wrote:
> ldionne wrote:
> > Yes!
> IMO `__memory_resource/memory_resource.h` should include the forward declaration, not the top-level header.
Ah, you're right, I actually mis-read the name of the header this was added in. Yup, this one should go away then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153216/new/

https://reviews.llvm.org/D153216



More information about the libcxx-commits mailing list