[libcxx-commits] [PATCH] D154499: [libc++] Do not use stringbuf's string after move

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 5 12:19:50 PDT 2023


philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

I am quite certain that `basic_stringbuf` has to be in a valid but unspecified state, meaning that you can't just check that the pointer are null. You have to find a way to exploit the issue without directly testing the values. For example, would the moved-to buffer get touched when writing to the moved-from stringbuf (or some other operation)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154499/new/

https://reviews.llvm.org/D154499



More information about the libcxx-commits mailing list