[libcxx-commits] [PATCH] D153778: [libc++][CI] Switches to CMake 3.27.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 5 08:58:50 PDT 2023


Mordante added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:37
   #
   - label: "Format"
     command: "libcxx/utils/ci/run-buildbot check-format"
----------------
ldionne wrote:
> Do you plan on reverting this patch once CMake 3.27 is the default in the CI? If so, is there a reason why we don't simply bump the default version in our Docker image now that we've validated it would work, and then abandon this patch?
The main reason not to do it is that this will break the LLVM-16 release branch. So I planned to revert this shortly before LLVM-17 is branched. I can also wait a few weeks and do it directly in main. At least we know the entire CI works CMake 3.27.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153778/new/

https://reviews.llvm.org/D153778



More information about the libcxx-commits mailing list